Cleanup texmanager. #10181
Merged
Cleanup texmanager. #10181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
cleanup-texmanager
branch
2 times, most recently
from
bfd122c
to
92b1bb4
Compare
|
get_ps_bbox was last used in 310e707 (2009) |
|
It looks like |
tacaswell
approved these changes
Jan 8, 2018
QuLogic
reviewed
Jan 8, 2018
lib/matplotlib/texmanager.py
Outdated
| break | ||
| else: | ||
| if DEBUG: | ||
| print('$s font is not compatible with usetex') | ||
| _log.debug('$s font is not compatible with usetex') |
There was a problem hiding this comment.
What is a $s font? Was this supposed to be a %s substitution?
lib/matplotlib/texmanager.py
Outdated
|
|
||
| def get_basefile(self, tex, fontsize, dpi=None): | ||
| """ | ||
| returns a filename based on a hash of the string, fontsize, and dpi | ||
| Returns a filename based on a hash of the string, fontsize, and dpi. |
There was a problem hiding this comment.
Since you're changing them all, the first line of the docstring should be imperative (Return, not Returns).
anntzer
force-pushed
the
cleanup-texmanager
branch
from
92b1bb4
to
31d8937
Compare
- remove check for "old" cache (the location changed in efa9ea6 (2005)). - postscriptd and pscnt are unused since c0d6110 (2006), deprecate them. - make_ps and make_ps_bbox are unused since 310e707 (2009), deprecate them. - calling \usepackage more than once with the same package does nothing (as a repeated import in Python) so no need to remove calls to \usepackage{type1cm}. - replace DEBUG by _log.debug where appropriate; other cases (forcing file regeneration) can be handled by manually deleting the old file. Various other minor cleanups.
anntzer
force-pushed
the
cleanup-texmanager
branch
from
31d8937
to
1d3a628
Compare
|
all comments are handled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(as a repeated import in Python) so no need to remove calls to
\usepackage{type1cm}.
file regeneration) can be handled by manually deleting the old file.
Various other minor cleanups.
PR Summary
PR Checklist